Enhance timeout settings and validation for HANA cluster operations#232
Merged
devanshjainms merged 2 commits intoAzure:development-feb-2026from Apr 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of HANA DB HA Ansible test scenarios by increasing wait timeouts, refining validation logic for scale-out worker operations, and refactoring network partition behavior to use site-wide iptables default DROP policies (with failure recovery).
Changes:
- Increase
default_timeoutfrom 60s to 90s for HA test waits. - Refactor the scale-out secondary network partition test to block all traffic on the secondary site (and adjust reporting).
- Tighten execution conditions/validation: gate primary-node kill to
SAPHanaSR-angiand improve scale-out worker post-checks; simplifychanged_when/failed_whenexpressions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vars/input-api.yaml |
Increases default wait timeout used across HA test tasks. |
src/roles/ha_db_hana/tasks/secondary-block-network.yml |
Refactors secondary-site network partition to iptables -P DROP with async delegated application and updated reporting/rescue flow. |
src/roles/ha_db_hana/tasks/primary-node-kill.yml |
Restricts primary node kill test execution to ANG I provider only. |
src/roles/ha_db_hana/tasks/includes/scaleout-worker-operation.yml |
Adjusts cluster validation criteria and removes unnecessary Jinja wrapping in changed_when/failed_when. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements and refactorings to the HANA DB high-availability Ansible roles, focusing on more robust and streamlined network partition testing, improved error handling, and minor logic corrections. The most important changes are grouped below:
Network Partition Test Refactoring and Robustness:
secondary-block-network.yml) is refactored to block all network communication on secondary site nodes usingiptables -P DROP, applied in parallel to all secondary nodes, instead of adding/removing individual firewall rules per IP. This simplifies the logic and ensures a more reliable partition. [1] [2]iptablespolicies to ACCEPT on secondary site nodes in case of test failure, ensuring the cluster is not left in a partitioned state.Logic and Validation Improvements:
saphanasr_provideris set toSAPHanaSR-angi, preventing unintended execution in other configurations.Timeout and Error Handling:
changed_whenandfailed_whenexpressions for better readability and reliability.Test Reporting:
These changes collectively improve the reliability, maintainability, and clarity of the HANA DB HA test automation.